SeqUtils asUInt endian-ness: hi/lo instead of right/left #1647
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist
docs/src
?Type of Improvement
API Impact
this changes the Chisel Naming from #1448 to notate endianness as "hi/lo" instead of "right/left", because Scala and Verilog use opposite endianness in lists/arrays
Backend Code Generation Impact
With #1448, this Chisel
would generate this Verilog:
This looks backwards to me when reading the Verilog: the rights and lefts are reversed. So instead, with this change:
Desired Merge Strategy
Release Notes
Verilog generation: asUInt endianness "hi/lo" instead of "right/left"
Reviewer Checklist (only modified by reviewer)
Please Merge
?