Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete index.md #1613

Merged
merged 2 commits into from
Oct 26, 2020
Merged

Delete index.md #1613

merged 2 commits into from
Oct 26, 2020

Conversation

azidar
Copy link
Contributor

@azidar azidar commented Oct 11, 2020 •
edited by seldridge
Loading

Causes issues when building the website, using these docs.

Contributor Checklist

  • [N/A] Did you add Scaladoc to every public function/method?
  • [N/A] Did you add at least one test demonstrating the PR?
  • [N/A] Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • [N/A] Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • [N/A] Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • bug fix

API Impact

No impact.

Backend Code Generation Impact

No impact.

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.0, 3.5.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@azidar
Delete index.md
c225967 
Causes issues when building the website, using these docs.
@azidar azidar added this to the 3.4.0 milestone Oct 11, 2020
@azidar azidar requested a review from a team as a code owner October 11, 2020 19:39
@azidar azidar requested review from chick and removed request for a team October 11, 2020 19:39
@seldridge seldridge modified the milestones: 3.4.0, 3.4.x Oct 26, 2020
@seldridge seldridge added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Oct 26, 2020
@mergify mergify bot merged commit 55809b1 into master Oct 26, 2020
mergify bot pushed a commit that referenced this pull request Oct 26, 2020
@azidar
Delete index.md (#1613)
bc3d7ce 
Causes issues when building the website, using these docs.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 55809b1)
@mergify mergify bot mentioned this pull request Oct 26, 2020
Merged
@mergify mergify bot added the Backported This PR has been backported label Oct 26, 2020
mergify bot added a commit that referenced this pull request Oct 26, 2020
@mergify @azidar
Delete index.md (#1613) (#1636)
9289491 
Causes issues when building the website, using these docs.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 55809b1)

Co-authored-by: Adam Izraelevitz <[email protected]>
@jackkoenig jackkoenig deleted the azidar-patch-1 branch July 7, 2021 03:44
@MAFOR-TECH MAFOR-TECH mentioned this pull request Oct 24, 2021
Closed
@sequencer sequencer mentioned this pull request Nov 8, 2021
Closed
jackkoenig pushed a commit that referenced this pull request Feb 28, 2023
@debs-sifive
Move Reg/Mem initializations to end of module (#1613)
1c8cec0 
* Move reg/mem initializations to end of module
* Add comment before reg/mem init if inits exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge approved these changes

@chick chick Awaiting requested review from chick

Assignees
No one assigned
Labels
Backported This PR has been backported Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
3.4.x
Development

Successfully merging this pull request may close these issues.
2 participants
@azidar @seldridge