Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New JSON structure #11

Merged
merged 11 commits into from
May 21, 2023
Merged

New JSON structure #11

merged 11 commits into from
May 21, 2023

Conversation

Timendus
Copy link
Collaborator

@Timendus Timendus commented May 11, 2023

TODO

  • Finish platforms.json
    • Add missing platforms
    • Write missing descriptions
  • Update README

Comparison to the other PR

Merging in the Space Invader meta data from #3, we now get this far:

  • Stored:
    • Title
    • Description (but closer to the "canonical" description)
    • Year of release
    • Author
    • Platform(s) as a complex entity
    • List of binaries instead of the one-on-one mapping
    • Keys
  • Not used:
    • Author objects (may revisit that in a future PR)
    • Images (that's definitely coming in a future PR)
    • Category -- don't really see the use yet if we have no way of filling that property
    • Version -- most ROMs have just one version, so left it out
    • All file names -- just the one for now; in fact, I'm considering removing file names all together because they are super unreliable for matching and thus add very little functionality
    • Source code meta data -- seems only useful if we also share source, but then why not just add the binaries to this repo too... 😄
    • Interpreter -- Could be fun to know, but again this is probably going to be a property that's almost always empty

@Timendus Timendus force-pushed the new-json-structure branch 3 times, most recently from 42cd38e to f05fa66 Compare May 15, 2023 19:20
@Timendus Timendus force-pushed the new-json-structure branch from 4439f69 to 7868648 Compare May 19, 2023 11:58
@Timendus Timendus marked this pull request as ready for review May 19, 2023 19:42
@Timendus Timendus mentioned this pull request May 19, 2023
@Timendus Timendus merged commit 6ef1a24 into master May 21, 2023
@Timendus Timendus deleted the new-json-structure branch May 21, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant