Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase testing of JWT validation #6

Merged
merged 2 commits into from
Apr 25, 2024
Merged

test: increase testing of JWT validation #6

merged 2 commits into from
Apr 25, 2024

Conversation

jamestelfer
Copy link
Collaborator

Improve testing, and simplify claims retrieval from context.

Using a panic here to simplify handler code. It's a misconfiguration if the middleware isn't present: expect this to be caught early.
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 36.66%. Comparing base (a268770) to head (2a52163).
Report is 3 commits behind head on jwt-tests.

Files Patch % Lines
handlers.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           jwt-tests       #6      +/-   ##
=============================================
+ Coverage      32.15%   36.66%   +4.51%     
=============================================
  Files             11       11              
  Lines            451      450       -1     
=============================================
+ Hits             145      165      +20     
+ Misses           295      274      -21     
  Partials          11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from jwt-tests to main April 25, 2024 12:56
@jamestelfer jamestelfer merged commit 96ea837 into main Apr 25, 2024
3 checks passed
@jamestelfer jamestelfer deleted the claims-tests branch April 25, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant