fix: allow HTTPS credentials when SSH configured #48
Conversation
|
Warning Rate Limit Exceeded@jamestelfer has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 38 minutes and 18 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent changes introduce a new function, Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant Tester
participant Vendor
Tester->>Vendor: Call TranslateSSHToHTTPS(sshURL)
Vendor-->>Tester: Return httpsURL
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 89.89% 90.02% +0.13%
==========================================
Files 12 12
Lines 455 461 +6
==========================================
+ Hits 409 415 +6
Misses 32 32
Partials 14 14 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- internal/vendor/vendor.go (3 hunks)
- internal/vendor/vendor_test.go (1 hunks)
Additional comments not posted (4)
internal/vendor/vendor.go (3)
7-7: Added import for"regexp"package.This is necessary for the new
TranslateSSHToHTTPSfunction which uses regular expressions.
64-66: Integration ofTranslateSSHToHTTPSin theNewfunction.This change aligns with the PR's objective to allow HTTPS credentials for SSH-configured repositories. Ensure that this logic is covered by unit tests to verify the correct transformation of URLs.
97-106: Implementation ofTranslateSSHToHTTPS.The function correctly uses a regular expression to transform SSH URLs to HTTPS URLs. However, consider adding error handling or logging for cases where the URL format does not match the expected pattern.
internal/vendor/vendor_test.go (1)
155-219: AddedTestTransformSSHToHTTPSfunction with comprehensive test cases.The test function is well-structured and covers a variety of scenarios for SSH to HTTPS URL transformation. This is crucial for ensuring the reliability of the
TranslateSSHToHTTPSfunction. Consider adding a test case for URLs that do not match any expected format to ensure that the function behaves correctly in unexpected scenarios.
Allow a pipeline to request HTTPS credentials of a repository that has been configured for SSH, as long as the requested repository matches the configured repository.
jamestelfer
force-pushed
the
translate-ssh
branch
from
fd8899a to
c573bdc
Compare
Allow a pipeline to request HTTPS credentials of a repository that has been configured for SSH, as long as the requested repository matches the configured repository.
Summary by CodeRabbit
New Features
Tests