Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license scan report and status #44

Closed
wants to merge 2 commits into from
Closed

Add license scan report and status #44

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a284d9c
Add license scan report and status
fossabot May 14, 2024
5e751bf
docs: fix formatting
jamestelfer Jun 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Chinmina Bridge: Buildkite/Github OIDC token bridge
Copy link

@coderabbitai coderabbitai bot May 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a blank line after the heading for proper markdown formatting.

+ 
# Chinmina Bridge: Buildkite/Github OIDC token bridge
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
# Chinmina Bridge: Buildkite/Github OIDC token bridge
# Chinmina Bridge: Buildkite/Github OIDC token bridge

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coderabbitai this is the first line of the file, no preceding blank line is required.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamestelfer, you are correct. Since this is the first line of the file, no preceding blank line is required. Thank you for pointing that out.


[![FOSSA Status](https://app.fossa.com/api/projects/git%2Bgithub.com%2Fjamestelfer%2Fchinmina-bridge.svg?type=shield)](https://app.fossa.com/projects/git%2Bgithub.com%2Fjamestelfer%2Fchinmina-bridge?ref=badge_shield)


Allows Buildkite agents to get valid GitHub tokens that can be used to perform
Git or other GitHub API actions. It is intended to be an alternative to the use
of SSH deploy keys or long-lived Personal Access Tokens.
Expand Down Expand Up @@ -241,3 +244,6 @@ Contributions are welcome.
- Execute `git` commands in the `.development/keys` directory. This has git
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the missing preposition "to" in the instruction.

- - Execute `git` commands in the `.development/keys` directory.
+ - Execute `git` commands in the `.development/keys` directory to use the local configuration.
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- Execute `git` commands in the `.development/keys` directory. This has git
- Execute `git` commands in the `.development/keys` directory to use the local configuration.
Tools
LanguageTool

[uncategorized] ~244-~244: Possible missing preposition found. (AI_HYDRA_LEO_MISSING_TO)
Context: ...Run make keygen to create test keys - Execute git commands in the `.development/key...

configuration set up so it uses a local credential helper that will use the
keys in the `.development/keys` directory.

## License
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a blank line after the "License" heading for proper markdown formatting.

248a249
+
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
## License
## License
Tools
Markdownlint

248-248: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines

[![FOSSA Status](https://app.fossa.com/api/projects/git%2Bgithub.com%2Fjamestelfer%2Fchinmina-bridge.svg?type=large)](https://app.fossa.com/projects/git%2Bgithub.com%2Fjamestelfer%2Fchinmina-bridge?ref=badge_large)