Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unreachable code in prvSelectHighestPriorityTask #70

Conversation

chinglee-iot
Copy link
Owner

Description

  • There should be at least idle task ready to run. Previous configASSERT ensure this function is called when scheduler is running.
configASSERT( xSchedulerRunning == pdTRUE );
  • The same reason xTaskScheduled is always true when leaving the while loop.
  • xLowestPriorityCore can't be greater than configNUMBER_OF_CORES due to the loop implementation.

Test Steps

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

* Remove unreachable assert condition
@chinglee-iot chinglee-iot requested a review from aggarg April 10, 2023 03:08
tasks.c Show resolved Hide resolved
@aggarg aggarg merged commit 23ce58e into smp-dev-complete-merge-candidate-history Apr 20, 2023
@aggarg aggarg deleted the fix-unreachable-code-prvSelectHighestPriorityTask branch April 20, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants