Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Express Router): breaking unmatched paths (non proxy routes) #98

Merged
merged 1 commit into from
Aug 11, 2016

Conversation

chimurai
Copy link
Owner

@chimurai chimurai commented Aug 7, 2016

fixes #94

req.url get rewritten even for non proxy routes.

Fix:
Only rewrite req.url when proxy routes matches.

@coveralls
Copy link

coveralls commented Aug 7, 2016

Coverage Status

Coverage increased (+0.006%) to 99.373% when pulling 1c3df2e on express-sub-route-fi into 306fdd4 on master.

@coveralls
Copy link

coveralls commented Aug 7, 2016

Coverage Status

Coverage increased (+0.006%) to 99.373% when pulling 2d5dff4 on express-sub-route-fi into 306fdd4 on master.

@coveralls
Copy link

coveralls commented Aug 11, 2016

Coverage Status

Coverage increased (+0.006%) to 99.373% when pulling 7deb5c3 on express-sub-route-fi into 306fdd4 on master.

@coveralls
Copy link

coveralls commented Aug 11, 2016

Coverage Status

Coverage increased (+0.006%) to 99.373% when pulling 7deb5c3 on express-sub-route-fi into 306fdd4 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't seem to recognize non proxy routes (express)
2 participants