fix(fixRequestBody): fix request body for empty JSON object requests

[mhassan1]

Description

This PR fixes the fixRequestBody utility so that it treats empty object bodies like non-empty object bodies and fixes them, as expected.

Motivation and Context

The fixRequestBody utility contains a check for empty objects that results in early return:

http-proxy-middleware/src/handlers/fix-request-body.ts

Lines 11 to 13 in c9bec81

	if (!requestBody || !Object.keys(requestBody).length) {
	return;
	}

Currently, JSON requests with empty object payloads do not get their request bodies fixed by this utility, and the request to the target hangs while the target waits for a payload that will never arrive.

This PR removes the special handling for empty objects and treats them like any other object.

Resolves #639.

How has this been tested?

I ran the reproduction steps in #639 before and after the code change. I also updated automated tests.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[eemelipa]

LGTM

Faced the same issue. Allowing empty objects in the body fixes it

[HappyColour]

This PR has been released right?

[eemelipa]

This PR has been released right?

I don't think so. The PR is still open and the library doesn't have the fix

[HappyColour]

This PR has been released right?

I don't think so. The PR is still open and the library doesn't have the fix

Thx bro @eemelipa,please confirm this pr has been merged @mhassan1.

[mhassan1]

No, it is still open.

[chimurai]

Hi @mhassan1. I left a remark in the PR a while ago which hasn't been resolved.

Happy to merge it after it's fixed.

Edit: Sorry, review was pending all the time. (bad github ui/ux) Should be visible now.

[mhassan1]

@chimurai This is ready for re-review.

[coveralls]

Coverage remained the same at 98.86% when pulling ece40cb on mhassan1:fix/fix-request-body-empty-json into 6b5d7a8 on chimurai:master.

[chimurai]

Thanks @mhassan1 !

[chimurai]

published in [email protected]