Self-references and += operator #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilles-duboscq
force-pushed
the
topic/self-reference
branch
from
fbe6904 to
fa7ad25
Compare
|
I'm not exactly sure what's going on with coveralls in the |
|
Thank you @gilles-duboscq ! This looks awesome! I'll review it this week. |
| continue # If value is present in latest version, don't do anything | ||
| if prop_path[0] == key and substitution.optional: | ||
| ConfigParser._do_substitute(substitution, None) | ||
|
|
There was a problem hiding this comment.
@sanzinger Really nice implementation for supporting self references! 👍
|
Thank you very much @sanzinger and @gilles-duboscq for implementing self reference and |
|
No problem. Thanks for the quick integration. |
|
@darthbear, @gilles-duboscq thank you for integrating that stuff. I never found the time to actually share it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges changes by @sanzinger that implement self-referential substitutions and the += operator.
The changes are a bit large so they are probably better reviewed commit by commit.
This would fix #35