Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#324): avoid parsing improperly periods on several lines with recent pyparsing versions #326

Merged
merged 2 commits into from
May 27, 2024

Conversation

pierresouchay
Copy link
Contributor

@pierresouchay pierresouchay commented May 24, 2024

periods were not correctly parsed with recent versions of pyparsing because of usage of White()

White is actually not needed, added some tests to avoid issues detected in #324

dates were not correctly parsed with recent versions of pyparsing because of usage of White()

White is actually not needed, added some tests to avoid issues detected in chimpler#324
@pierresouchay pierresouchay changed the title fix for https://github.com/chimpler/pyhocon/issues/324 fix(#324): avoid parsing improperly periods on several lines with recent pyparsing versions May 24, 2024
@pierresouchay
Copy link
Contributor Author

Hello @darthbear ,

Could you consider this change as it broke with recent pyparsing releases?

@darthbear darthbear merged commit dbed4b1 into chimpler:master May 27, 2024
1 check passed
@pierresouchay
Copy link
Contributor Author

@darthbear Thank you!

@darthbear
Copy link
Member

Thanks for your contribution @pierresouchay! Released new version 0.3.61

@pierresouchay
Copy link
Contributor Author

Thank you so much @darthbear !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants