Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix required(file()) syntax #229

Merged
merged 1 commit into from
May 26, 2020
Merged

Fix required(file()) syntax #229

merged 1 commit into from
May 26, 2020

Conversation

jrouly
Copy link
Contributor

@jrouly jrouly commented May 11, 2020 •
edited
Loading

This PR applies the suggested fix from #187 and adds a test for it as well.

Seems to work on my machine.

@chimpler

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 96.146% when pulling 8c39103 on jrouly:fix-required-file into d242459 on chimpler:master.

@darthbear
Copy link
Member

Thanks for the fix @jrouly !

@darthbear darthbear merged commit 0b653ec into chimpler:master May 26, 2020
@jrouly jrouly mentioned this pull request May 26, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrouly @coveralls @darthbear