Added an example with png rounded modules using gd

[livingroot]

Result:

Similar to:
#127

[codemasher]

Oh wow, this is incredible! Just let me have a quick look over the commit. 🚀

[codemasher]

Also, i noticed that your branch is like 6 months behind dev-main - could you please update and check if it still works for you (spoiler: it probably won't and I'm currently trying to find out why).

[codemasher]

Update: it's because the setPixel() method has ben renamed to module() for consistency across the several output classes.

[livingroot]

Thank you for your review, i will fix this issues. But i can't see dev-main branch. Did you mean main?

[codemasher]

Yes, main it is - dev-main is the composer name - a habit of mine i guess haha.

[livingroot]

All done! However, I am not sure about PHPCS complaining about single if conditions like if ($neighbours & (1 << 3)) {. I think it would be even worse for readability if this condition had additional brackets. Should I add them too?

[livingroot]

Also, I have checked that everything is working fine

[codemasher]

All done! However, I am not sure about PHPCS complaining about single if conditions like if ($neighbours & (1 << 3)) {. I think it would be even worse for readability if this condition had additional brackets. Should I add them too?

I agree that this case is a bit weird, but there's no way to my knowledge to exclude these cases via the xml config. I have added them throughout the library for consistency, alternatively you can just disable the ckech for that line with a // phpcs:ignore.

Also, I have checked that everything is working fine

That's great! Thank you for your contribution! 🚀

[codemasher]

This causes an "implicit conversion from float to int" exception in imagefilledrectangle() -> cast to int or use intdiv()

[codemasher]

You could also intercept the constructor to enable the internal upscaling for "rounder" corners at lower scales (which would be counter-intuitive for the user to set):

	public function __construct(SettingsContainerInterface $options, QRMatrix $matrix){
		$options->drawCircularModules = true;

		parent::__construct($options, $matrix);
	}