Slack webhooks shlex

childmindresearch · Jan 5, 2024 · 66d38d4 · 66d38d4
1 parent 227d729
commit 66d38d4
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/src/ecpac/slack.py b/src/ecpac/slack.py
@@ -1,5 +1,6 @@
 import json
 import os
+import shlex
 
 SLACK_WEBHOOK_URL: str | None = os.environ.get("SLACK_WEBHOOK_URL")
 
@@ -13,7 +14,16 @@ def slack_message_bash(data: dict) -> str:
     """Generate a bash command to send a message to Slack."""
     if not slack_webhook_available():
         return ""
-    return f"curl -X POST -H 'Content-type: application/json' --data '{json.dumps(data)}' {SLACK_WEBHOOK_URL}"
+    return shlex.join([
+        "curl",
+        "-X",
+        "POST",
+        "-H",
+        "Content-type: application/json",
+        "--data",
+        json.dumps(data),
+        SLACK_WEBHOOK_URL
+    ])
 
 
 def slack_message_bash_mrkdwn(text: str) -> str: