Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to translate strings and a fix for .mo file generation #741

Closed
wants to merge 6 commits into from

Conversation

raivisdejus
Copy link
Collaborator

Current version of msgfmt.py is producing .mo files that cause app crash with Latvian translations. Refactored it to use polib that works fine.

Also wrapping some string is translation function to make them translatable

Copy link

codecov bot commented May 18, 2024

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 74.22%. Comparing base (38f5d26) to head (99ece45).
Report is 2 commits behind head on main.

Current head 99ece45 differs from pull request most recent head f17149b

Please upload reports for the commit f17149b to get more accurate results.

Files Patch % Lines
...ferences_dialog/folder_watch_preferences_widget.py 75.00% 2 Missing ⚠️
...ts/preferences_dialog/models_preferences_widget.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #741      +/-   ##
==========================================
- Coverage   81.28%   74.22%   -7.06%     
==========================================
  Files          81       83       +2     
  Lines        3617     3884     +267     
==========================================
- Hits         2940     2883      -57     
- Misses        677     1001     +324     
Flag Coverage Δ
Linux 74.22% <90.62%> (?)
Windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raivisdejus raivisdejus enabled auto-merge (squash) May 23, 2024 16:34
@raivisdejus
Copy link
Collaborator Author

Will recreate this PR against branch from original repo, so builds work as expected
#752

auto-merge was automatically disabled May 23, 2024 18:24

Pull request was closed

@raivisdejus raivisdejus deleted the fix-locale branch May 23, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant