Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eliminate Django 1.11 from tox.ini #208

Closed
wants to merge 2 commits into from
Closed

eliminate Django 1.11 from tox.ini #208

wants to merge 2 commits into from

Conversation

mmautner
Copy link

@mmautner mmautner commented Mar 6, 2018

Fix broken master build: #207

Django 1.9 support was dropped in DRF 3.7 as 1.9 is EOL:

encode/django-rest-framework#5457

@mmautner
Copy link
Author

mmautner commented Mar 6, 2018

@auvipy @chibisov

@auvipy
Copy link
Collaborator

auvipy commented Mar 7, 2018

the proper PR would be to drop anything less then 1.11 and should move to 1.11 and 2.x supported versions only

@mmautner
Copy link
Author

mmautner commented Mar 7, 2018

@auvipy the master branch of this repo has failing tests--the build status icon at the top of the README is red, the README makes no mention of supporting 1.11:

screen shot 2018-03-07 at 7 56 06 am

Why would anyone use this library? Maybe tests should be passing for 1.11 before suggesting what "the proper PR" should be!

@auvipy
Copy link
Collaborator

auvipy commented Mar 8, 2018

master branch is not in pypi so no one is bound to use the broken master. since master is meant to be the development branch it is not unusual to be broken sometime before release, but we will definitely make build green before release. and master branch is for futuristic development the next release will get full 1.11 and 2.x support along with the drop of legacy versions. so if you want to contribute anything really useful try to fix some tests broken in 1.11.

@auvipy auvipy closed this Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants