Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Django 1.11 #187

Closed
clintonb opened this issue May 30, 2017 · 11 comments
Closed

Add Support for Django 1.11 #187

clintonb opened this issue May 30, 2017 · 11 comments
Assignees

Comments

@clintonb
Copy link

clintonb commented May 30, 2017

Update Travis/tox to test with Django 1.11. Resolve any compatibility issues.

This would also be a good time to add support for Python 3.6.

@auvipy auvipy self-assigned this Aug 17, 2017
@auvipy
Copy link
Collaborator

auvipy commented Aug 18, 2017

lets see if I can make it by this month

auvipy pushed a commit that referenced this issue Sep 11, 2017
* Added Django 1.11 to tox

* Stripped " from ETag for Django 1.11

* Added Travis configs for Django 1.11

* Limited Django 1.11 tox to not include Django 2.0
@barseghyanartur
Copy link

Django 1.11 support has already been added in the code (and in tests). Please, make a new PyPI release.

@auvipy
Copy link
Collaborator

auvipy commented Jan 11, 2018

tests are still failing

@barseghyanartur
Copy link

@auvipy:

Wow. Any (realistic) ideas/estimates on when would it be implemented?

@auvipy
Copy link
Collaborator

auvipy commented Jan 11, 2018

contributions are welcome

@barseghyanartur
Copy link

@auvipy:

With all the respect, that's not what I was asking about.

@clintonb
Copy link
Author

@barseghyanartur what are you asking about? The functionality is mostly present, but the tests are failing. Django 1.11 should not be officially supported until the tests for Django 1.11 pass. @auvipy and @MightySCollins took the time to contribute a significant portion of the effort about four months ago. No one else has picked up where they left off, so the package doesn't officially support Django 1.11.

The majority of the contributors to this package are volunteers. I'd be happy to review your test fixes and help get Django 1.11 support out the door, if you're willing to volunteer your time and expertise.

@barseghyanartur
Copy link

@clintonb:

My question was very simple and direct. I asked about realistic estimates on when would it be implemented. If there are no plans to upgrade to 1.11 or no clear road-map, better say so.

@clintonb
Copy link
Author

Based on the inactivity regarding this issue, there is no defined time for support of Django 1.11.

@MightySCollins
Copy link
Contributor

Yep looking though the tests unfortunately it seems Django changed some of the etag stuff this package relies on. Looking at the test fails I assume this package will not work correctly with caching in Django 1.11 but with the fix in #197 stops just using the etags breaking. Because of this we have been using it in production now Django 2.0 for quite some time but not using drf-extensions to handle the caching just adding the etag header.

I have a feeling most of the issues are to do with the test_with_middleware which is failing and that it might just be a case of the strings or there methods changing slightly but don't have the time to look into it much more right now.

@auvipy
Copy link
Collaborator

auvipy commented Mar 8, 2018

#209 more fixes. plz review and help to detect the remaining failures

@auvipy auvipy closed this as completed Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants