Allow columns option to be more generic type than list (Fixes #389) #390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Convert columns parameter to a list prior to checking it is identical to a sorted list, so it will now work, e.g. with a tuple.
Changed the type hint from Iterable to Sequence to reflect the fact that that it must have a consistent order. (Sequence doesn't formally guarantee this, but it is implicit in the definition.)
Motivation and Context
Fixes issue #389.
How Has This Been Tested?
nox has been run. Although errors were found, these were the same errors as in master, and were unrelated to this change.
Types of changes
Checklist: