Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation in bopomofo module #582

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Conversation

wusyong
Copy link
Contributor

@wusyong wusyong commented Jun 4, 2024

Fix #367.

  • Removed all TODO and added the missing documents.
  • Add trivia to make enum variants document layout slightly better.

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.29%. Comparing base (d48ebab) to head (0bf64b3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #582   +/-   ##
=======================================
  Coverage   89.29%   89.29%           
=======================================
  Files          38       38           
  Lines        8221     8221           
=======================================
  Hits         7341     7341           
  Misses        880      880           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/zhuyin/bopomofo.rs Outdated Show resolved Hide resolved
@wusyong wusyong requested a review from kanru June 4, 2024 04:47
@kanru kanru added this pull request to the merge queue Jun 4, 2024
Merged via the queue into chewing:master with commit 329d547 Jun 4, 2024
12 checks passed
@wusyong wusyong deleted the doc-bopomofo branch June 4, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: document the zhuyin::bopomofo module
2 participants