Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(keys): Ed25519VerificationKey2020 full spec compliant & add 2018 support [DEV-2017] #497

Merged
merged 44 commits into from
Jan 6, 2023

Conversation

lampkin-diet
Copy link
Contributor

No description provided.

@Eengineer1 Eengineer1 self-requested a review January 3, 2023 10:47
@Eengineer1 Eengineer1 changed the title fix: Change validation for ED25519VerificationKey2020 due to spec fix: Change validation for Ed25519VerificationKey2020 due to spec Jan 3, 2023
@Eengineer1 Eengineer1 changed the title fix: Change validation for Ed25519VerificationKey2020 due to spec fix: Fix Ed25519VerificationKey2020 full spec compliant & add 2018 support Jan 3, 2023
Copy link
Contributor

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP

@Eengineer1 Eengineer1 changed the title fix: Fix Ed25519VerificationKey2020 full spec compliant & add 2018 support fix(keys): Ed25519VerificationKey2020 full spec compliant & add 2018 support Jan 3, 2023
@Eengineer1 Eengineer1 requested a review from ankurdotb January 5, 2023 16:21
@ankurdotb ankurdotb changed the title fix(keys): Ed25519VerificationKey2020 full spec compliant & add 2018 support fix(keys): Ed25519VerificationKey2020 full spec compliant & add 2018 support [DEV-2017] Jan 6, 2023
@ankurdotb
Copy link
Contributor

Task linked: DEV-2017 Fix on ledger

@ankurdotb ankurdotb changed the title fix(keys): Ed25519VerificationKey2020 full spec compliant & add 2018 support [DEV-2017] feat(keys): Ed25519VerificationKey2020 full spec compliant & add 2018 support [DEV-2017] Jan 6, 2023
@ankurdotb ankurdotb enabled auto-merge (squash) January 6, 2023 16:47
@ankurdotb ankurdotb self-requested a review January 6, 2023 16:49
@ankurdotb ankurdotb dismissed Eengineer1’s stale review January 6, 2023 16:50

Fix by Tasos already

@ankurdotb ankurdotb merged commit 2aa528b into develop Jan 6, 2023
@ankurdotb ankurdotb deleted the dev-2017 branch January 6, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants