Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ibc): Bump IBC to v3 and update associated upgrade tests [DEV-807] #334

Merged
merged 21 commits into from
Jul 4, 2022
Merged

feat(ibc): Bump IBC to v3 and update associated upgrade tests [DEV-807] #334

merged 21 commits into from
Jul 4, 2022

Conversation

askolesov
Copy link
Contributor

@askolesov askolesov commented Jun 28, 2022 •
edited
Loading

TODO: Redirect to main once resource module is merged

@ankurdotb
Copy link
Contributor

Task linked: DEV-807 Bump IBC version

@askolesov askolesov changed the base branch from main to DEV-1281-resource-module June 28, 2022 10:17
@ankurdotb ankurdotb marked this pull request as ready for review June 28, 2022 10:42
ankurdotb
ankurdotb requested changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@ankurdotb ankurdotb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check Osmosis version. The max_gas doesn't make much difference but let's keep it consistent.

tests/e2e-complex/ibc-defi/hermes/config.toml Outdated Show resolved Hide resolved
tests/e2e-complex/ibc-defi/osmosis/osmosis.Dockerfile Outdated Show resolved Hide resolved
@askolesov askolesov marked this pull request as draft June 29, 2022 11:43
Base automatically changed from DEV-1281-resource-module to main June 30, 2022 13:46
@askolesov askolesov requested a review from ankurdotb June 30, 2022 17:01
@askolesov askolesov marked this pull request as ready for review June 30, 2022 17:01
@askolesov
Copy link
Contributor Author

Tests are WIP

ankurdotb
ankurdotb requested changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@ankurdotb ankurdotb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to run at least one test with Osmosis v10

@askolesov askolesov requested a review from ankurdotb July 4, 2022 13:45
@ankurdotb ankurdotb changed the title chore: Ibc bump (DEV-807) feat(ibc): Bump IBC to v3 and update associated upgrade tests [DEV-807] Jul 4, 2022
@ankurdotb ankurdotb merged commit f5fae32 into main Jul 4, 2022
@ankurdotb ankurdotb deleted the ibc-bump branch July 4, 2022 14:43
ankurdotb added a commit that referenced this pull request Jul 4, 2022
@ankurdotb
Squashed commit of the following:
d2c5470 
commit f5fae32
Author: Alexander Kolesov <[email protected]>
Date:   Mon Jul 4 17:43:57 2022 +0300

    feat(ibc): Bump IBC to v3 and update associated upgrade tests [DEV-807] (#334)

    * Fixed IBC test
    * Bump IBC to v3.x
    * Clean-up app bootstrapping
    * Remove unused Gravity DEX IBC test
    * Bump Osmosis to v10 in IBC test
    * Make `max_gas` consistent with production networks
    * Fix merge conflicts
    * Supress version pins in Dockerfiles for Hadolint linter
    * Fix linter issues
    * Remove checksum validation
    * Updated docker-compose with cheqd to use standard Dockerfile
    * Process review issues
    * Suppress DL3022 errors in Hadolint

    Co-authored-by: Ankur Banerjee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankurdotb ankurdotb ankurdotb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@askolesov @ankurdotb