Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add resource module (DEV-1281) #330

Merged
merged 76 commits into from
Jun 30, 2022
Merged

feat: Add resource module (DEV-1281) #330

merged 76 commits into from
Jun 30, 2022

Conversation

Toktar
Copy link
Contributor

@Toktar Toktar commented Jun 14, 2022

No description provided.

@ankurdotb
Copy link
Contributor

Task linked: DEV-1281 Implement DID Schema on the ledger

@Toktar Toktar marked this pull request as draft June 14, 2022 14:42
@Toktar Toktar marked this pull request as ready for review June 15, 2022 12:55
@Toktar Toktar marked this pull request as draft June 15, 2022 12:55
askolesov and others added 19 commits June 16, 2022 10:41
@askolesov
Fixing validation / build
6e85cf1
@askolesov
Implementing resources creation
7a8c739
@Toktar
dev-1281: add resource unit tests
a908508
@Toktar
Merge branch 'DEV-1281-resource-module' of github.com:cheqd/cheqd-nod…
63250f0 
…e into DEV-1281-resource-module
@askolesov
Fixing tests
0bc8a81
@askolesov
Minimal resource creation
5125db7
@Toktar
dev-1281: update resource unit tests
5b0524f
@askolesov
Implementation of createResource cli command
b0f45bb
@askolesov
Fix createResource bash test
f7a5bda
@Toktar
dev-1281: add resource query
6669a4a
@Toktar
Merge branch 'DEV-1281-resource-module' of github.com:cheqd/cheqd-nod…
c80bcad 
…e into DEV-1281-resource-module
@Toktar
dev-1281: update tests
e1522ba
Add validation for resourceType and MimeType
28d4ab2
Merge branch 'DEV-1281-resource-module' of github.com:cheqd/cheqd-nod…
62fb818 
…e into DEV-1281-resource-module
Add created and checksum for Resource
cbdbe4a
@askolesov
Fixing backlinks from diddocx to resources
1006313
@askolesov
Merge branch 'DEV-1281-resource-module' of https://github.com/cheqd/c…
7d3c314 
…heqd-node into DEV-1281-resource-module
@askolesov
Add files for queries
c69dd23
Move cheqcksum to bytes
2eb9da7
@askolesov askolesov requested a review from lampkin-diet June 21, 2022 14:25
@askolesov askolesov requested a review from ankurdotb June 21, 2022 15:40
askolesov
askolesov previously approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@askolesov askolesov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ready.

@askolesov askolesov marked this pull request as ready for review June 24, 2022 13:29
ankurdotb
ankurdotb requested changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@ankurdotb ankurdotb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes here, and some things to discuss

proto/resource/v1/query.proto Outdated Show resolved Hide resolved
tests/e2e-bash/tests/test_create_resource.sh Outdated Show resolved Hide resolved
x/cheqd/client/cli/tx.go Show resolved Hide resolved
x/resource/client/cli/tx_create_resource.go Outdated Show resolved Hide resolved
x/resource/client/cli/tx_create_resource_raw.go Outdated Show resolved Hide resolved
x/resource/keeper/keeper_resource.go Show resolved Hide resolved
x/resource/tests/constants.go Show resolved Hide resolved
x/resource/utils/media_type.go Show resolved Hide resolved
@askolesov askolesov requested a review from ankurdotb June 29, 2022 14:47
@askolesov askolesov merged commit a8222e9 into main Jun 30, 2022
@askolesov askolesov deleted the DEV-1281-resource-module branch June 30, 2022 13:46
@Toktar Toktar mentioned this pull request Jul 26, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askolesov askolesov askolesov left review comments

@ankurdotb ankurdotb ankurdotb approved these changes

@lampkin-diet lampkin-diet Awaiting requested review from lampkin-diet

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Toktar @ankurdotb @askolesov