-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEV-1096] Improve release processes #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askolesov
previously approved these changes
Mar 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @anikitinDSR! Great work, a lot of improvements, new cool solutions. Code looks clean. The only thing - I would discuss it with @ankurdotb. If he is OK with this approach, let's merge this PR.
ankurdotb
reviewed
Apr 5, 2022
Signed-off-by: Andrew Nikitin <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
* Deactivate lint and release workflows * Deactivate lint workflow dependency * [DEV-1096] Revert changes and fix pipelines Signed-off-by: Andrew Nikitin <[email protected]> * [DEV-1096] Remove set pipefail for workflow Signed-off-by: Andrew Nikitin <[email protected]> * [DEV-1096] add script instead of one command Signed-off-by: Andrew Nikitin <[email protected]> * [DEV-1096] Change node to localhost Signed-off-by: Andrew Nikitin <[email protected]> * [DEV-1096] Fix release pipelines Signed-off-by: Andrew Nikitin <[email protected]> * [DEV-1096] fix release pipeline Signed-off-by: Andrew Nikitin <[email protected]> * [DEV-1096] debug release Signed-off-by: Andrew Nikitin <[email protected]> * [DEV-1096] Fix release tagging Signed-off-by: Andrew Nikitin <[email protected]> Co-authored-by: Ankur Banerjee <[email protected]>
* Deactivate lint and release workflows * Deactivate lint workflow dependency * [DEV-1096] Revert changes and fix pipelines Signed-off-by: Andrew Nikitin <[email protected]> * [DEV-1096] Remove set pipefail for workflow Signed-off-by: Andrew Nikitin <[email protected]> * [DEV-1096] add script instead of one command Signed-off-by: Andrew Nikitin <[email protected]> * [DEV-1096] Change node to localhost Signed-off-by: Andrew Nikitin <[email protected]> * [DEV-1096] Fix release pipelines Signed-off-by: Andrew Nikitin <[email protected]> * [DEV-1096] fix release pipeline Signed-off-by: Andrew Nikitin <[email protected]> * [DEV-1096] debug release Signed-off-by: Andrew Nikitin <[email protected]> * [DEV-1096] Fix release tagging Signed-off-by: Andrew Nikitin <[email protected]> * [DEV-1096] fix build Signed-off-by: Andrew Nikitin <[email protected]> * [DEV-1096] Remove unused script Signed-off-by: Andrew Nikitin <[email protected]> * [DEV-1096] debug Signed-off-by: Andrew Nikitin <[email protected]> * [DEV-1096] fix variable passing Signed-off-by: Andrew Nikitin <[email protected]> Co-authored-by: Ankur Banerjee <[email protected]>
ankurdotb
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Nikitin [email protected]