Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV-1079: Split validation into basic and dynamic #285

Merged
merged 94 commits into from
Mar 18, 2022
Merged

DEV-1079: Split validation into basic and dynamic #285

merged 94 commits into from
Mar 18, 2022

Conversation

askolesov
Copy link
Contributor

No description provided.

@ankurdotb
Copy link
Contributor

Task linked: DEV-705 [performance] Split validation into basic and dynamic.

@ankurdotb ankurdotb changed the title DEV-705: Slit validation into basic and dynamic DEV-705: Split validation into basic and dynamic Feb 18, 2022
ankurdotb
ankurdotb requested changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@ankurdotb ankurdotb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discuss and check versionId deviation from
ADR. I know that when we launched, this wasn't correctly being set to the tx hash, and I would expect that as part of this validation, we validate it against the correct format that makes sense.

x/cheqd/types/stateValue.go Show resolved Hide resolved
@ankurdotb ankurdotb marked this pull request as ready for review February 23, 2022 16:07
ankurdotb
ankurdotb previously approved these changes Feb 23, 2022
View reviewed changes
@askolesov askolesov marked this pull request as draft February 24, 2022 12:38
@lampkin-diet lampkin-diet mentioned this pull request Feb 24, 2022
Closed
@rosspower11 rosspower11 changed the title DEV-705: Split validation into basic and dynamic DEV-1079: Split validation into basic and dynamic Feb 25, 2022
ankurdotb
ankurdotb reviewed Feb 28, 2022
View reviewed changes
Copy link
Contributor

@ankurdotb ankurdotb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@askolesov Can I confirm that this is still WIP and not ready for review?

go.mod Show resolved Hide resolved
ankurdotb
ankurdotb reviewed Mar 8, 2022
View reviewed changes
Copy link
Contributor

@ankurdotb ankurdotb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have the chance to fully work through the logic here on allowed DID namespace, but basically it must match the one in the genesis file.

x/cheqd/types/validate.go Outdated Show resolved Hide resolved
@askolesov
Copy link
Contributor Author

While this is not in the list of changed files, can we please change the path in query.proto L14 from option (google.api.http).get = "/cheqd/cheqdnode/cheqd/did/{id}"; to option (google.api.http).get = "/cheqd/v1/did/{id}"; This is more consistent with the Cosmos SDK REST API naming convention.

Good point, changed

Also, at what point would/should that be changed from cheqd/v1 to a different version? Should it be increased in step with module Consensus version, or not?

It's up to us. I think we should change the version once we change models. + Ideally, we should keep previous versions for some time.

@askolesov
Copy link
Contributor Author

@ankurdotb @Toktar I've answered all threads. Could you please review one more time? Thanks in advance!

ankurdotb
ankurdotb previously approved these changes Mar 17, 2022
View reviewed changes
Andrew Nikitin and others added 10 commits March 18, 2022 11:30
[DEV-705] fix upgrade tests
c91ca1e 
Signed-off-by: Andrew Nikitin <[email protected]>
[DEV-705] fix upgrade test
e06c6ff 
Signed-off-by: Andrew Nikitin <[email protected]>
[DEV-705] Fix upgrade test
6784128 
Signed-off-by: Andrew Nikitin <[email protected]>
[DEV-705] fix upgrade test
afea105 
Signed-off-by: Andrew Nikitin <[email protected]>
[DEV-705] Fix upgrade test
60af20c 
Signed-off-by: Andrew Nikitin <[email protected]>
[DEV-705] Fix upgrade test again
e85ae31 
Signed-off-by: Andrew Nikitin <[email protected]>
[DEV-705] get -d back
4af599c 
Signed-off-by: Andrew Nikitin <[email protected]>
[DEV-705] Get rid of --ver-key
4916717 
Signed-off-by: Andrew Nikitin <[email protected]>
[DEV-705] Get local_tx_send back
e41afb1 
Signed-off-by: Andrew Nikitin <[email protected]>
@askolesov
Merge pull request #300 from cheqd/DEV-705-did-validation
b094a0b 
[DEV-705] e2e test fixes
ankurdotb
ankurdotb requested changes Mar 18, 2022
View reviewed changes
tests/e2e-complex/upgrade/common.sh Show resolved Hide resolved
tests/e2e-complex/upgrade/upgrade_and_check.sh Outdated Show resolved Hide resolved
ankurdotb
ankurdotb previously approved these changes Mar 18, 2022
View reviewed changes
@askolesov askolesov merged commit 1ad0c88 into main Mar 18, 2022
@askolesov askolesov deleted the DEV-705 branch March 18, 2022 11:35
@Toktar
Copy link
Contributor

Toktar commented Mar 18, 2022

Approved by @Toktar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankurdotb ankurdotb ankurdotb left review comments

@lampkin-diet lampkin-diet Awaiting requested review from lampkin-diet

@Toktar Toktar Awaiting requested review from Toktar

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@askolesov @ankurdotb @Toktar @lampkin-diet