Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV 841: Further docker, tests improvements #280

Merged
merged 45 commits into from
Feb 24, 2022
Merged

DEV 841: Further docker, tests improvements #280

merged 45 commits into from
Feb 24, 2022

Conversation

askolesov
Copy link
Contributor

No description provided.

@ankurdotb
Copy link
Contributor

Task linked: DEV-841 Docker Compose + Actions pipeline improvements

askolesov and others added 26 commits February 11, 2022 18:40
@askolesov
New docker compose draft
6fdd4f6
@ankurdotb
Comment out build section
3dbb39d
@askolesov
Fix docker builds
06d9676
@askolesov
Merge branch 'DEV-841' of https://github.com/cheqd/cheqd-node into DE…
bf83691 
…V-841
@askolesov
Working docker-compose based localnet
bf8984b
@askolesov
Fix doc
095ebc8
@askolesov
Fix localnet setup
4da78e5
@askolesov
Fix image name
de21c86
@askolesov
Fix test paths
c628e3a
@askolesov
Fix paths
026539c
@askolesov
Fix paths
80b3cf0
@askolesov
Expose RPC ports
d217cc0
@askolesov
Add docker version output
746ac1f
@askolesov
Print docker compose version
b1188b7
@askolesov
Docker compose version
a030f3a
@askolesov
Revert docker compose version print
d88973e
@askolesov
Fix paths
11f5cf2
@askolesov
Make other steps to use compose based localnet
139627b
@askolesov
Remove testnet image building and publishing
d03a807
@askolesov
Fix ports
5cc114e
@askolesov
Comment external address
1c21d9e
@askolesov
Remove external address from localnet nodes
5aa0037
@askolesov
Fix paths
b6d2f4e
@askolesov
Get rid of configure mapping in docker entrypoint script
f8a79fa
@askolesov
Add api, consensus configuration to localnet
fc194c6
@askolesov
Fix paths in the upgrade test
668107c
@askolesov askolesov changed the title Further docker, tests improvements [DEV 841] DEV 841: Further docker, tests improvements Feb 16, 2022
@askolesov askolesov marked this pull request as ready for review February 17, 2022 10:07
ankurdotb
ankurdotb requested changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@ankurdotb ankurdotb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @askolesov, I know this is a huge PR. Please take a look at the comments highlighted and take a look at what you agree with / to fix.

A few generic comments (that applies to multiple nodes)

  • Set fast sync version to v0 (if not already done in code)
  • Set minimum gas price (to be equivalent to production networks)
  • Try setting create empty blocks to false (if it isn’t already by default)

.github/workflows/release.yml Outdated Show resolved Hide resolved
docker/entrypoint.sh Show resolved Hide resolved
docker/localnet/container-env/observer-0.env Show resolved Hide resolved
docker/localnet/container-env/seed-0.env Show resolved Hide resolved
docker/localnet/docker-compose.env Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
@askolesov
Copy link
Contributor Author

@ankurdotb Thanks for the review! Happy to discuss the comments above in huddle to close this PR faster if it's OK for you.

* Set fast sync version to v0 (if not already done in code)

It's v0 by default.

* Set minimum gas price (to be equivalent to production networks)

Good point, fixed.

* Try setting create empty blocks to false (if it isn’t already by default)

Done.

@askolesov askolesov requested a review from ankurdotb February 21, 2022 16:17
ankurdotb
ankurdotb reviewed Feb 21, 2022
View reviewed changes
Copy link
Contributor

@ankurdotb ankurdotb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final few discussions to close out

cmd/cheqd-noded/cmd/debug_extensions.go Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
@ankurdotb ankurdotb mentioned this pull request Feb 21, 2022
Closed
@askolesov askolesov requested a review from ankurdotb February 22, 2022 10:05
@askolesov askolesov merged commit e5160fc into main Feb 24, 2022
@askolesov askolesov deleted the DEV-841 branch February 24, 2022 12:39
lampkin-diet pushed a commit that referenced this pull request Feb 28, 2022
@askolesov @ankurdotb
DEV 841: Further docker, tests improvements (#280)
5f7b8fb 
* Restructure tests

* Remove libindy

* Remove docker-localnet image

* New docker compose draft

* Comment out build section

* Fix docker builds

* Working docker-compose based localnet

* Fix doc

* Fix localnet setup

* Fix image name

* Fix test paths

* Fix paths

* Fix paths

* Expose RPC ports

* Add docker version output

* Print docker compose version

* Docker compose version

* Revert docker compose version print

* Fix paths

* Make other steps to use compose based localnet

* Remove testnet image building and publishing

* Fix ports

* Comment external address

* Remove external address from localnet nodes

* Fix paths

* Get rid of configure mapping in docker entrypoint script

* Add api, consensus configuration to localnet

* Fix paths in the upgrade test

* Fix linter issues

* For the previous commit

* Make container.env to utilize cosmos native env vars

* Revert unnecessary changes

* Add new line at the EOF

* Remove remainings of the testnet image

* Extract env vars of testnet into separate files

* Fix images publishing

* Move import-keys script to localnet

* Set default minimum gas prices for localnet

* Set CREATE_EMPTY_BLOCKS to false

* Replace PAT with GITHUB_TOKEN

* Fix registry name in release pipeline

* Add missing seed_mode

* Fix panic in case of invalid key format (#284)

Co-authored-by: Ankur Banerjee <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
lampkin-diet pushed a commit that referenced this pull request Feb 28, 2022
@askolesov @ankurdotb
DEV 841: Further docker, tests improvements (#280)
90c2a93 
* Restructure tests

* Remove libindy

* Remove docker-localnet image

* New docker compose draft

* Comment out build section

* Fix docker builds

* Working docker-compose based localnet

* Fix doc

* Fix localnet setup

* Fix image name

* Fix test paths

* Fix paths

* Fix paths

* Expose RPC ports

* Add docker version output

* Print docker compose version

* Docker compose version

* Revert docker compose version print

* Fix paths

* Make other steps to use compose based localnet

* Remove testnet image building and publishing

* Fix ports

* Comment external address

* Remove external address from localnet nodes

* Fix paths

* Get rid of configure mapping in docker entrypoint script

* Add api, consensus configuration to localnet

* Fix paths in the upgrade test

* Fix linter issues

* For the previous commit

* Make container.env to utilize cosmos native env vars

* Revert unnecessary changes

* Add new line at the EOF

* Remove remainings of the testnet image

* Extract env vars of testnet into separate files

* Fix images publishing

* Move import-keys script to localnet

* Set default minimum gas prices for localnet

* Set CREATE_EMPTY_BLOCKS to false

* Replace PAT with GITHUB_TOKEN

* Fix registry name in release pipeline

* Add missing seed_mode

* Fix panic in case of invalid key format (#284)

Co-authored-by: Ankur Banerjee <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
lampkin-diet pushed a commit that referenced this pull request Feb 28, 2022
@askolesov @ankurdotb
DEV 841: Further docker, tests improvements (#280)
f9806ec 
* Restructure tests

* Remove libindy

* Remove docker-localnet image

* New docker compose draft

* Comment out build section

* Fix docker builds

* Working docker-compose based localnet

* Fix doc

* Fix localnet setup

* Fix image name

* Fix test paths

* Fix paths

* Fix paths

* Expose RPC ports

* Add docker version output

* Print docker compose version

* Docker compose version

* Revert docker compose version print

* Fix paths

* Make other steps to use compose based localnet

* Remove testnet image building and publishing

* Fix ports

* Comment external address

* Remove external address from localnet nodes

* Fix paths

* Get rid of configure mapping in docker entrypoint script

* Add api, consensus configuration to localnet

* Fix paths in the upgrade test

* Fix linter issues

* For the previous commit

* Make container.env to utilize cosmos native env vars

* Revert unnecessary changes

* Add new line at the EOF

* Remove remainings of the testnet image

* Extract env vars of testnet into separate files

* Fix images publishing

* Move import-keys script to localnet

* Set default minimum gas prices for localnet

* Set CREATE_EMPTY_BLOCKS to false

* Replace PAT with GITHUB_TOKEN

* Fix registry name in release pipeline

* Add missing seed_mode

* Fix panic in case of invalid key format (#284)

Co-authored-by: Ankur Banerjee <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankurdotb ankurdotb ankurdotb approved these changes

@lampkin-diet lampkin-diet Awaiting requested review from lampkin-diet

@Toktar Toktar Awaiting requested review from Toktar

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@askolesov @ankurdotb