Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix codecs #255

Merged
merged 4 commits into from
Dec 23, 2021
Merged

Fix codecs #255

merged 4 commits into from
Dec 23, 2021

Conversation

askolesov
Copy link
Contributor

@askolesov askolesov commented Dec 15, 2021 •
edited
Loading

Fixed cheqd types registration.
Fixed proto packing/unpacking.

These issues caused panic during nymList export to genesis.

@ankurdotb ankurdotb requested a review from Toktar December 16, 2021 01:54
ankurdotb
ankurdotb reviewed Dec 20, 2021
View reviewed changes
Copy link
Contributor

@ankurdotb ankurdotb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment left behind regarding something that seems wrong on namespace. And just to confirm, this is overridden by genesis file namespace if it's present correct?

x/cheqd/types/keys.go Show resolved Hide resolved
@ankurdotb ankurdotb marked this pull request as draft December 20, 2021 16:27
@askolesov askolesov changed the title Split validation into static and dynamic Fix codecs Dec 22, 2021
@askolesov askolesov marked this pull request as ready for review December 22, 2021 14:58
@askolesov
Copy link
Contributor Author

This PR seems to be self-contained. Static validation will be implemented in another one.

ankurdotb
ankurdotb reviewed Dec 22, 2021
View reviewed changes
Copy link
Contributor

@ankurdotb ankurdotb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs one final discussion tomorrow before closing out

@askolesov askolesov requested a review from ankurdotb December 23, 2021 10:57
@askolesov
Copy link
Contributor Author

Can we merge this now? I've created a ticket to migrate did-namespace key name: https://app.clickup.com/t/6600954/DEV-804.

@ankurdotb ankurdotb merged commit af09cd7 into main Dec 23, 2021
@ankurdotb ankurdotb deleted the feature/static-validation branch December 23, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankurdotb ankurdotb ankurdotb approved these changes

@Toktar Toktar Awaiting requested review from Toktar

@lampkin-diet lampkin-diet Awaiting requested review from lampkin-diet

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@askolesov @ankurdotb