Documentation about API for keys and pool methods. #133
Conversation
|
@ankurdotb Looks like there will be several ADRs that are cheqd related but about VDR Tools. What is the right place for them? |
I don't see this document as an ADR, it's more a developer documentation for how to use the software. Good question on whether it should be here though: if it's about how to use VDR Tools, then I'd expect it to be im VDR Docs but we can link to those docs from ours. Is there doc site similar to docs.cheqd.io for VDR Tools? |
There was a problem hiding this comment.
We should discuss this...it seems there are things being implemented here that are duplicates of what cheqd Cosmos CLI is meant to achieve. To me, this would go against what we decided in the ADR for CLI tools: https://docs.cheqd.io/node/architecture/adr-list/adr-003-cli-tools
More broadly though, VDR Tools SDK should assume the network is already up and running, and no configuration tasks are expected to be carried out from VDR Tools. Broadcast as a concept also doesn't make sense to me.
There was a problem hiding this comment.
Minor comments on method names, would be good to understand if we're sticking with this for now and refactoring later (this is fine by me if that's the decision on the VDR Tools side / it's not easy to change right now).
Otherwise, I've resolved a whole bunch of other comments after the clarification regarding usage of some methods.
Last thing remaining besides confirming method names is there's a minor update needed for account names, where the prefix has now changed.
Looks good otherwise! Thanks @anikitinDSR
Signed-off-by: Andrew Nikitin <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
ankurdotb
force-pushed
the
pool_connection_md
branch
from
0540c31 to
013edfe
Compare
Matched the pool config docs for internal style guidelines
No description provided.