Rene hamburger1993 patch 1 #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drop cols containing None before grouping. Speeds the function up in my case: ~x5 when called as `fp.to_dataframe(return_atoms=True,drop_empty=True)`
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
=======================================
Coverage 95.74% 95.74%
=======================================
Files 10 10
Lines 1081 1082 +1
=======================================
+ Hits 1035 1036 +1
Misses 46 46
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Since dropping empty columns is optional (controlled by I'll merge once you confirm (and the pipeline checks are green). Thanks again for contributing! Best, |
|
looks fine to me! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #112