circle for the bond query feature is not centered

[lpatiny]

If you press q when over a bond there is a dialog box allowing to edit query features

However the circle that represents the fact that this bond is special is not centered on the bond

You can test it online: https://cheminfo.github.io/openchemlib-js/dist/Editor.html

[lpatiny]

It must be related to the different behaviour between java and javascript. Java draw an ellipse and toe x, y value is the top left. while in javascript we specify the center.

[targos]

can you post links to the relevant source code?

[lpatiny]

Java:

• openchemlib-js/src/com/actelion/research/gwt/chemlib/com/actelion/research/chem/Depictor.java

  Lines 104 to 106 in ac1a763

  	protected void fillCircle(double x, double y, double r) {
  	((Graphics)mG).fillOval((int)Math.round(x), (int)Math.round(y), (int)Math.round(r), (int)Math.round(r));
  	}

• https://github.com/cheminfo/openchemlib-js/blob/master/src/com/actelion/research/gwt/chemlib/com/actelion/research/chem/Depictor2D.java#L125-L130

Javascript, centered based:

• https://github.com/cheminfo/openchemlib-js/blob/master/src/com/actelion/research/gwt/gui/viewer/GWTDepictor.java#L151-L160
• https://github.com/cheminfo/openchemlib-js/blob/master/src/com/actelion/research/gwt/chemlib/com/actelion/research/chem/SVGDepictor.java#L160-L168

[lpatiny]

Seems to me it is called from only one place that is common between java and javascript:
https://github.com/cheminfo/openchemlib-js/blob/master/src/com/actelion/research/gwt/chemlib/com/actelion/research/chem/AbstractDepictor.java#L707-L726

I guess the solution would be that for SVG and GWT depictor we add the radius.

[targos]

the SVG depictor is in the original code

[targos]

what do you mean by "add the radius" ? the radius seems to be used everywhere?

[rufenerc]

Guys, do you need some help? Christian

…

On 30 Nov 2018, at 16:26, Michaël Zasso ***@***.***> wrote: the SVG depictor is in the original code — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#63 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJmvoc2z537rkz-_IL9FVu_Ybs_IvgAaks5u0U5CgaJpZM4Y5EKQ>.

[rufenerc]

I see the problem.
Give me some time I guess I can manage this.

[lpatiny]

@rufenerc Please could you also have a look at #62 and maybe comment on #65 ?

If you could also send me by email your new email address. I could not invite you for the workshop last time.

[rufenerc]

Fixed in commit 09edf53

[targos]

The issue is still present in the SVG depictor. I may have time to fix it tomorrow.