Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue rendering an organometallic complex SMILES #130

Closed
felipe-imanishi opened this issue May 25, 2022 · 6 comments · Fixed by #135
Closed

Issue rendering an organometallic complex SMILES #130

felipe-imanishi opened this issue May 25, 2022 · 6 comments · Fixed by #135

Comments

@felipe-imanishi
Copy link

felipe-imanishi commented May 25, 2022

We have this canonical SMILES generated by RDKIT CNc1ccccc1-c1[c-]cccc1.COc1ccc(OC)c(P(C2CCCCC2)C2CCCCC2)c1-c1c(C(C)C)cc(C(C)C)cc1C(C)C.CS(=O)(=O)O.[Pd] that fails to render in openchemlib. If we remove the negatively charged carbon (the - in the [c-], it renders but it is then incorrect.

Is there a limitation here or is this known?

The original smiles (before being canonicalized by RDKIT) CC(C)C1=CC(=C(C(=C1)C(C)C)C2=C(C=CC(=C2P(C3CCCCC3)C4CCCCC4)OC)OC)C(C)C.CNC1=CC=CC=C1C2=CC=CC=[C-]2.CS(=O)(=O)O.[Pd] does render, but because we are using rdkit as our standardization tool, it is not possible for us to use this smiles.

Thank you!

Image below is from chemdraw. It shows both smiles mentioned plotted.
The first one is for smiles CNc1ccccc1-c1[c-]cccc1.COc1ccc(OC)c(P(C2CCCCC2)C2CCCCC2)c1-c1c(C(C)C)cc(C(C)C)cc1C(C)C.CS(=O)(=O)O.[Pd] and the second one for smiles CC(C)C1=CC(=C(C(=C1)C(C)C)C2=C(C=CC(=C2P(C3CCCCC3)C4CCCCC4)OC)OC)C(C)C.CNC1=CC=CC=C1C2=CC=CC=[C-]2.CS(=O)(=O)O.[Pd].

Screen Shot 2022-05-25 at 9 22 03 AM

@targos
Copy link
Member

targos commented May 28, 2022

/cc @thsa as this is probably not specific to the JS port of OpenChemLib

@lpatiny
Copy link
Member

lpatiny commented Jul 6, 2022

The error code is 'Assignment of aromatic double bonds failed'. Currently openchemlib do not accept c1[c-]cccc1

@thsa
Copy link

thsa commented Jul 11, 2022 via email

@felipe-imanishi
Copy link
Author

@targos what is the release cadence for openchemlib-js? With the fix above, I was wondering when openchemlib-js would be able to make a release to include this release https://github.com/Actelion/openchemlib/releases/tag/openchemlib-2022.7.2 from openchemlib. Thank you!

@targos
Copy link
Member

targos commented Jul 20, 2022

Unfortunately I tried to update openchemlib last year and there were issues preventing the compilation. I haven't found the time to resolve them yet, so for now this is blocked on either me finding the time or someone else doing it (I'd be happy to review a pull request)

@targos targos linked a pull request Aug 14, 2022 that will close this issue
@targos
Copy link
Member

targos commented Aug 14, 2022

I'll do a release as soon as #135 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants