Migrate to GitHubs v4 API #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit the new command made some assumptions about how tags worked. Annotated tags contain a tagger reference which has a pointer to when the tag was created and also the commit that the tag points to. Lightweight tags are just a pointer to a commit and therefore contain no tagger information. The assumption that lightweight tags also contained the tagger reference meant that entries were not being added to the correct bucket. This commit fixes that (hopefully) by using the v4 api to retrieve a list of tag refs that are either lightweight or annotated. This allows us to access the correct date depending on the type of ref that is returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR the new command made some assumptions about how tags worked.
Annotated tags contain a tagger reference which has a pointer to when the tag was created and also the commit that the tag points to.
Lightweight tags are just a pointer to a commit and therefore contain no tagger information.
The assumption that lightweight tags also contained the tagger reference meant that entries were not being added to the correct bucket.
This PR fixes that (hopefully) by using the v4 api to retrieve a list of tag refs that are either lightweight or annotated. This allows us to access the correct date depending on the type of ref that is returned.