Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): use scala 3 lts version #273

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Conversation

updraft0
Copy link
Contributor

@updraft0 updraft0 commented Feb 12, 2025

The current latest version is using the latest Scala 3.6 compiler, which means other projects based on Scala 3 that are not on that version cannot use it because of dependency conflicts:

[error] java.io.IOException: TASTy file scala/Tuple$package.tasty could not be read, failing with:
[error]   Forward incompatible TASTy file has version 28.6, produced by Scala 3.6.3-bin-nonbootstrapped,
[error]   expected stable TASTy from 28.0 to 28.5.
[error]   To read this TASTy file, use a newer version of this tool compatible with TASTy 28.6.
[error]   Please refer to the documentation for information on TASTy versioning:
[error]   https://docs.scala-lang.org/scala3/reference/language-versions/binary-compatibility.html

I'm not sure there is anything here that requires the newer Scala compilers and cannot be on LTS.

However, the build does fail, one of the examples has this issue: scala/scala3#20741 so perhaps that's the reason it's like that. Happy to find a workaround to make this LTS scala build happen though.

Sadly there doesn't seem to be a way currently to make renovate not update to latest version either: renovatebot/renovate#31281 and renovatebot/renovate#27632

@updraft0
Copy link
Contributor Author

Ok, I can't seem to use @nowarn in any obvious place to suppress the warning laminar-form-derivation/core/src/main/scala/magnolia1/impl.scala: the type test for Color cannot be checked at runtime because it's a local class

@cheleb
Copy link
Owner

cheleb commented Feb 12, 2025

Hey,
Thank for this contrib, TBH I tend to align on last version naturally, on my projects (pet and pro) ...
BTW, @guillaug WDYT ?

@updraft0
Copy link
Contributor Author

Hey, Thank for this contrib, TBH I tend to align on last version naturally, on my projects (pet and pro) ... BTW, @guillaug WDYT ?

I think the current suggested path for library authors is to use the LTS versions - for all the reasons outlined in Long-term compatibility plans for Scala 3 - Library Maintainers but of course that's up to you. I just have a project that has some issues with dependencies moving to 3.6 so would need to keep a fork of this library.

@cheleb
Copy link
Owner

cheleb commented Feb 12, 2025

No, please don't, I will merge tonight and draft a release (I is a personal project ... )

@updraft0
Copy link
Contributor Author

No, please don't, I will merge tonight and draft a release (I is a personal project ... )

Oh cool - that wasn't a threat btw but simply hard to make sbt + public CI to work otherwise. Looking forward to the next version then!

@cheleb cheleb merged commit 6200df7 into cheleb:master Feb 12, 2025
1 of 2 checks passed
@cheleb
Copy link
Owner

cheleb commented Feb 12, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants