Remove Solaris 10 platform and enable some hardening flags on Linux/Mac/FreeBSD #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this adds -D_FORTIFY_SOURCE=2 -fstack-protector by default. since most linux distros have this enabled by default this should be safe to do. dunno about windows. our AIX builds don't use gcc. Signed-off-by: Lamont Granquist <[email protected]>
Signed-off-by: Lamont Granquist <[email protected]>
|
https://idea.popcount.org/2013-08-15-fortify_source/ was a helpful reference, I wasn't familiar with the effects of those flags . |
marcparadise
approved these changes
Nov 14, 2019
Signed-off-by: Lamont Granquist <[email protected]>
|
dang you're fast |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't build or support Solaris 10 any more since it is EOL
This adds
-D_FORTIFY_SOURCE=2 -fstack-protectorto Linux/Mac/BSD. Tried to add it to Solaris and it failed. AIX is not gcc so its not applicable, and Windows mostly terrifies me.This is likely a NOP since most distros have added this anyway, but it establishes a baseline.
This passed tests here:
https://buildkite.com/chef/chef-chef-master-omnibus-adhoc/builds/133
On 15.5.2 on Ubuntu we already have these settings:
This might do something useful like enable hardening on RHEL6 but I didn't exhaustively check.