Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEN-123] Fix IPS package must create symlinks to package commands #727

Conversation

jaymalasinha
Copy link
Contributor

@jaymalasinha jaymalasinha commented Oct 24, 2016

Description

IPS package creation script looks for symlinks.erb in local project resources and adds them to
manifest file so the IPS package will install symlinks from the template. These are the links added by post install scripts for other package types. But since IPS does not use post install scripts they need to be added here.

Fixes issue: chef/chef#5458


/cc @chef/omnibus-maintainers <- This ensures the Omnibus Maintainers team are notified to review this PR.
@chef/engineering-services

Maintainers

Please ensure that you check for:

  • [] If this change impacts git cache validity, it bumps the git cache
    serial number
  • [] If this change impacts compatibility with omnibus-software, the
    corresponding change is reviewed and there is a release plan
  • [] If this change impacts compatibility with the omnibus cookbook, the
    corresponding change is reviewed and there is a release plan
    • Looks for symlinks.erb in project directories and adds them to
      manifest file
    • Add unit tests for symlinks file creation
    • Update unit tests for manifest file creation

Signed-off-by: Jaymala Sinha [email protected]

  - Looks for symlinks.erb in project directories and adds them to
    manifest file
  - Add unit tests for symlinks file creation
  - Update unit tests for manifest file creation

Signed-off-by: Jaymala Sinha [email protected]
@jaymalasinha jaymalasinha force-pushed the jsinha/BEN-123-IPSFIX branch from b97eb49 to d2b8304 Compare October 24, 2016 16:57
@scotthain
Copy link
Contributor

I think you'll want to merge this to master then we can cherry-pick it to rhass/COOL-502_with_gcc_investigate - does that sound correct?

@jaymalasinha
Copy link
Contributor Author

closing this rebasing to master instead. Will submit a new PR for master branch

@yzl yzl removed the in progress label Oct 24, 2016
@jaymalasinha jaymalasinha deleted the jsinha/BEN-123-IPSFIX branch October 25, 2016 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants