Fix mono builddate capture and add debug logging #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Things seems to have changed in the output in the last billion years. Include the full standard out and add a spec.
| end | ||
| languages[:mono] = mono if mono[:version] | ||
| rescue Ohai::Exceptions::Exec | ||
| Ohai::Log.debug('Mono plugin: Could not shell_out "mono -v". Skipping plugin') |
|
🚀 |
|
@chef/client-core this is ready for review |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't capturing the builddate right based on the latest output. I don't have an example of the old output to know if something changed or if this ever worked right. We didn't have specs that included the data or a check for the attribute. Those are added now.