Add language scala

[cmluciano]

No description provided.

[thommay]

LGTM 👍

[cmluciano]

@mcquin good on your side?

[mcquin]

LGTM

Should we add a languages/scala/sbt attribute, based on the presence of sbt? These aren't packaged together, but they tend to go hand-in-hand.

[cmluciano]

Sounds great to me. Should we collect just the sbt info or also say that if sbt is found, we should label this machine as having the language scala installed?

[mcquin]

Some people may have scala, but not sbt.

I'm +1 for having sbt as a subattribute of languages/scala (i.e, provides "languages/scala/sbt") which would contain version info (scala[:sbt][:version] = ...), or be nil if sbt is not present on the system (scala[:sbt] = nil).

[cmluciano]

@mcquin I added a step to check for sbt.

[mcquin]

[nitpick] Looks like you've got two spaces after your = sign.

[mcquin]

Some minor things, but looking great @cmluciano ! =)

[mcquin]

👍

[cmluciano]

Can we get a few more 👍 from @chef/client-core

[mcquin]

We need another review from @chef/client-core

[ranjib]

👍
Q: do we know if sbt -version and scala -version will slow down ohai ?

[mcquin]

@ranjib Added time appears negligible

	time scala -version	time sbt --version
os x w/ scala, sbt installed	0.36s user 0.07s system 0.368 total	0.32s user 0.08s system 0.322 total
ubuntu vm w/o scala, sbt installed	real 0m0.115s user 0m0.038s sys 0m0.071s	real 0m0.115s user 0m0.038s sys 0m0.071s

[danielsdeleo]

Unless we've done something special in Ohai, this isn't what happens when scala isn't installed. On my machine:

[1] pry(main)> require 'mixlib/shellout'
=> true
[2] pry(main)> include Mixlib
=> Object
[3] pry(main)> c = ShellOut.new("scala -v")
=> <Mixlib::ShellOut#70321135567700: command: 'scala -v' process_status: nil stdout: '' stderr: '' child_pid: nil environment: {} timeout: 600 user:  group:  working_dir:  >
[4] pry(main)> c.run_command
Errno::ENOENT: No such file or directory - scala
from /Users/ddeleo/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/mixlib-shellout-2.1.0/lib/mixlib/shellout/unix.rb:338:in `exec'

I think ohai still catches all failures and ignores them, but it'd be nice to rescue that instead.

[mcquin]

Huh. I assumed shellout caught these errors, appears that is not the case. Good to know, taking note.

[cmluciano]

Should I just remove this context?

[mcquin]

No, don't remove this context.

Dan's comment shows shell_out("scala -v") throws an Errno::ENOENT, rather than returning what's been mocked here. The spec should be updated to reflect that behavior.

[mcquin]

LGTM

[btm]

What are the two begin/end blocks for?

Does it make sense if we can't find scala to return rather than look for sbt too?

[lamont-granquist]

Yeah the begin/end should go and the initial check should probably just be a shell_out! and let the exception abort the plugin.

[cmluciano]

Ok begin/end have been removed. Just waiting on CI :)

[cmluciano]

Failures seemed related to style, fixed up

[mcquin]

👍 @chef/client-core

[tas50]

This needs to go after the check for the exist status. Otherwise we get an empty hash when scala isn't around.

[mcquin]

Ohai won't add attribute to its data until you do attribute Mash.new.

[tas50]

Ignore me