Ensure that arguments to Mixlib::Log#add are passed as is to all loggers #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch @ketan. This is 👍 for me. Any concerns @opscode/client-eng ? |
|
LGTM |
sersut
pushed a commit
that referenced
this pull request
May 21, 2014
Ensure that arguments to Mixlib::Log#add are passed as is to all loggers
|
Thanks @ketan for the patch again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm attempting to wrap mixlib log with ActiveRecord::TaggedLogger which calls #add on the logger it wraps, it so happens that Mixlib logger breaks in such a situation because it does not pass the arguments transparently to the loggers that it wraps in turn. Thereby causing the logs to print a log message with blank message in it.
For the implementation of TaggedLogger see https://github.com/rails/rails/blob/v3.2.6/activesupport/lib/active_support/tagged_logging.rb#L35