Optimize our requires #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid requiring things that are already defined. Rubygems is very slow at traversing the filesystem. Signed-off-by: Tim Smith <[email protected]>
phiggins
approved these changes
Aug 21, 2020
Signed-off-by: Tim Smith <[email protected]>
phiggins
reviewed
Aug 21, 2020
spec/mixlib/log/formatter_spec.rb
Outdated
| @@ -16,7 +16,7 @@ | |||
| # limitations under the License. | |||
| # | |||
|
|
|||
| require "time" | |||
| require "time" unless defined?(Time) | |||
There was a problem hiding this comment.
This one is probably not a good candidate for optimizing this way:
irb(main):001:0> defined?(Time)
=> "constant"
irb(main):002:0> Time.new
=> 2020-08-21 11:28:12 -0700
irb(main):003:0> Time.new.iso8601
Traceback (most recent call last):
4: from /Users/pete/.asdf/installs/ruby/2.6.6/bin/irb:23:in `<main>'
3: from /Users/pete/.asdf/installs/ruby/2.6.6/bin/irb:23:in `load'
2: from /Users/pete/.asdf/installs/ruby/2.6.6/lib/ruby/gems/2.6.0/gems/irb-1.0.0/exe/irb:11:in `<top (required)>'
1: from (irb):3
NoMethodError (undefined method `iso8601' for 2020-08-21 11:28:19 -0700:Time)
irb(main):004:0> require 'time'
=> true
irb(main):005:0> Time.new.iso8601
=> "2020-08-21T11:28:24-07:00"
There was a problem hiding this comment.
Yeah I was just looking at that one. That's not gonna work
There was a problem hiding this comment.
I updated Chefstyle and this PR to check for a specific method
Signed-off-by: Tim Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid requiring things that are already defined. Rubygems is very slow at traversing the filesystem.
Signed-off-by: Tim Smith [email protected]