Resolve all warnings emitted during testing #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the code run nearly warning free, reducing the output of `rspec -w spec` by 42 lines. That has to mean something, right? Signed-off-by: Ryan Davis <[email protected]>
Signed-off-by: Ryan Davis <[email protected]>
marcparadise
approved these changes
Jun 6, 2019
This makes it testable using minitest/rspec IO assertions/expectations. STDOUT/STDERR should only be used to restore $stdout/$stderr if something goes haywire. The globals should be used for everyday use. Also bolstered an IO test to prevent the output from going to the rspec result output. Signed-off-by: Ryan Davis <[email protected]>
Otherwise the tests were resetting twice per. Signed-off-by: Ryan Davis <[email protected]>
Also removed a line that didn't have the effect intended. Those were class-ivars, not ivars. Signed-off-by: Ryan Davis <[email protected]>
|
poke. I'd merge this but apparently I don't have perms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all warnings emitted during testing of mixlib-log or inspec.
Description
ruby -w,rspec -w, andminitest -wall run with$-w = trueand output warnings on use of uninitialized variables among other things. This PR cleans those up for this project. It also changes some tests around to be more idiomatic and to avoid logging going to stdout on top of the rspec output.Types of changes
Checklist: