Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuboCop lint rules, linting, TODO config added #25

Closed

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Aug 16, 2017

This PR adds a RuboCop configuration file with quite few excludes and such.

  • lines in this projects are wider
  • double quotes are double
  • the features/ directory has code generated by Cucumber, so I excluded it

This all makes us compatible with chefstyle 0.6.0.

@olleolleolle
Copy link
Contributor Author

olleolleolle commented Aug 16, 2017

Now, in order to reach "DCO" status, I'd need to re-do these commits.

Would a squash into a single commit be too dramatic? (Here, a single commit, with a DCO.)

@olleolleolle olleolleolle force-pushed the feature/rubocop-ruleset-added branch from f960289 to b317039 Compare August 16, 2017 14:14
@olleolleolle olleolleolle force-pushed the feature/rubocop-ruleset-added branch from 54950e8 to f237a8c Compare August 17, 2017 08:56
@olleolleolle olleolleolle force-pushed the feature/rubocop-ruleset-added branch from 4a0fe8f to ca3b731 Compare August 17, 2017 09:23
@olleolleolle olleolleolle force-pushed the feature/rubocop-ruleset-added branch from 20eda70 to acffcb4 Compare August 17, 2017 10:54
Signed-off-by: Olle Jonsson <[email protected]>
@olleolleolle
Copy link
Contributor Author

olleolleolle commented Aug 17, 2017

I filed this PR to rake, to get around the issue that it exposes its own .rubocop.yml in its downloaded files: ruby/rake#217

This is fixed here by us not including vendor/ in the scope of files to check.

@tas50
Copy link
Contributor

tas50 commented Aug 17, 2017

@olleolleolle Any reason to not just use Chefstyle with the stock config like we're doing elsewhere?

@olleolleolle
Copy link
Contributor Author

@tas50 Oh, I learned about Chefstyle while doing this change. But I failed to realize how much it takes care of.

(The first thing I did was to run rubocop, which failed, and so on. And, then incrementally, I took steps to make things work more and more. At the end, I saw that the Travis CI script (Rake default task) had a style task, so I began using that, even asking it to do "-a" for auto-correct.)

Gah.

So, can I close this with no change?

@olleolleolle
Copy link
Contributor Author

Closing this with no change.

@olleolleolle olleolleolle deleted the feature/rubocop-ruleset-added branch November 21, 2017 15:20
@chef chef locked and limited conversation to collaborators Apr 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants