-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RuboCop lint rules, linting, TODO config added #25
RuboCop lint rules, linting, TODO config added #25
Conversation
Now, in order to reach "DCO" status, I'd need to re-do these commits. Would a squash into a single commit be too dramatic? (Here, a single commit, with a DCO.) |
Signed-off-by: Olle Jonsson <[email protected]>
f960289
to
b317039
Compare
Signed-off-by: Olle Jonsson <[email protected]>
54950e8
to
f237a8c
Compare
Signed-off-by: Olle Jonsson <[email protected]>
Signed-off-by: Olle Jonsson <[email protected]>
4a0fe8f
to
ca3b731
Compare
Signed-off-by: Olle Jonsson <[email protected]>
20eda70
to
acffcb4
Compare
Signed-off-by: Olle Jonsson <[email protected]>
I filed this PR to This is fixed here by us not including |
@olleolleolle Any reason to not just use Chefstyle with the stock config like we're doing elsewhere? |
@tas50 Oh, I learned about Chefstyle while doing this change. But I failed to realize how much it takes care of. (The first thing I did was to run Gah. So, can I close this with no change? |
Closing this with no change. |
This PR adds a RuboCop configuration file with quite few excludes and such.
features/
directory has code generated by Cucumber, so I excluded itThis all makes us compatible with chefstyle 0.6.0.