Skip to content

Commit

Permalink
Merge pull request #51 from chef/github
Browse files Browse the repository at this point in the history
Expand testing / Update GitHub templates
  • Loading branch information
tas50 authored Apr 23, 2019
2 parents 7ad076b + 6345a13 commit c78a384
Show file tree
Hide file tree
Showing 11 changed files with 94 additions and 9 deletions.
7 changes: 5 additions & 2 deletions .expeditor/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ github:
version_tag_format: "v{{version}}"
# allow bumping the minor release via label
minor_bump_labels:
- "Expeditor: Bump Minor Version"
- "Expeditor: Bump Version Minor"
# allow bumping the major release via label
major_bump_labels:
- "Expeditor: Bump Version Major"

changelog:
rollup_header: Changes not yet released to rubygems.org
Expand All @@ -30,7 +33,7 @@ merge_actions:
only_if: built_in:bump_version
- built_in:update_changelog:
ignore_labels:
- "Expeditor: Exclude From Changelog"
- "Expeditor: Skip Changelog"
- "Expeditor: Skip All"
- built_in:build_gem:
only_if: built_in:bump_version
Expand Down
5 changes: 3 additions & 2 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# Order is important. The last matching pattern has the most precedence.

* @chef/client-maintainers
.expeditor/** @chef/jex-team
* @chef/chef-infra-reviewers
.expeditor/** @chef/jex-team
*.md @chef/docs-team
Original file line number Diff line number Diff line change
@@ -1,8 +1,16 @@
---
name: � Bug Report
about: If something isn't working as expected �.
labels: "Status: Untriaged"
---

# Version:

[Version of the project installed]

# Environment: [Details about the environment such as the Operating System, cookbook details, etc...]
# Environment:

[Details about the environment such as the Operating System, cookbook details, etc...]

# Scenario:

Expand Down
40 changes: 40 additions & 0 deletions .github/ISSUE_TEMPLATE/DESIGN_PROPOSAL.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
---
name: Design Proposal
about: I have a significant change I would like to propose and discuss before starting
labels: "Status: Untriaged"
---

### When a Change Needs a Design Proposal

A design proposal should be opened any time a change meets one of the following qualifications:

- Significantly changes the user experience of a project in a way that impacts users.
- Significantly changes the underlying architecture of the project in a way that impacts other developers.
- Changes the development or testing process of the project such as a change of CI systems or test frameworks.

### Why We Use This Process

- Allows all interested parties (including any community member) to discuss large impact changes to a project.
- Serves as a durable paper trail for discussions regarding project architecture.
- Forces design discussions to occur before PRs are created.
- Reduces PR refactoring and rejected PRs.

---

<!--- Proposal description and rationale. -->

## Motivation

<!---
As a <<user_profile>>,
I want to <<functionality>>,
so that <<benefit>>.
-->

## Specification

<!--- A detailed description of the planned implementation. -->

## Downstream Impact

<!--- Which other tools will be impacted by this work? -->
17 changes: 17 additions & 0 deletions .github/ISSUE_TEMPLATE/ENHANCEMENT_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
---
name: 🚀 Enhancement Request
about: I have a suggestion (and may want to implement it 🙂)!
labels: "Status: Untriaged"
---

### Describe the Enhancement:
<!--- What you are trying to achieve that you can't? -->

### Describe the Need:
<!--- What kind of user do you believe would utilize this enhancement, and how many users might want this functionality -->

### Current Alternative
<!--- Is there a current alternative that you can utilize to workaround the lack of this enhancement -->

### Can We Help You Implement This?:
<!--- The best way to ensure your enhancement is built is to help implement the enhancement yourself. If you're interested in helping out we'd love to give you a hand to make this possible. Let us know if there's something you need. -->
11 changes: 11 additions & 0 deletions .github/ISSUE_TEMPLATE/SUPPORT_QUESTION.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
name: 🤗 Support Question
about: If you have a question 💬, please check out our Slack!
---

We use GitHub issues to track bugs and feature requests. If you need help please post to our Mailing List or join the Chef Community Slack.

* Chef Community Slack at http://community-slack.chef.io/.
* Chef Mailing List https://discourse.chef.io/

Support issues opened here will be closed and redirected to Slack or Discourse.
3 changes: 2 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,11 @@
### Issues Resolved

[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussion that's relevant]
StackOverflow discussions that are relevant]

### Check List

- [ ] New functionality includes tests
- [ ] All tests pass
- [ ] All commits have been signed-off for the Developer Certificate of Origin. See <https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco>
- [ ] PR title is a worthy inclusion in the CHANGELOG
1 change: 1 addition & 0 deletions .github/lock.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
daysUntilLock: 60
6 changes: 3 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@ matrix:
include:
- rvm: 2.3.8
- rvm: 2.4.5
- rvm: 2.5.3
- rvm: 2.6
- rvm: 2.5.5
- rvm: 2.6.2
- rvm: ruby-head
allow_failures:
- rvm: ruby-head

branches:
only:
- master
- master

bundler_args: --without docs development

Expand Down
1 change: 1 addition & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Please refer to https://github.com/chef/chef/blob/master/CONTRIBUTING.md
2 changes: 2 additions & 0 deletions appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ cache:

environment:
matrix:
- ruby_version: "24-x64"
- ruby_version: "25-x64"
- ruby_version: "26-x64"

clone_depth: 1
skip_tags: true
Expand Down

0 comments on commit c78a384

Please sign in to comment.