Fix Amazon 2 detection #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The elif that looks for /etc/system-release was firing for Amazon 2 and the /etc/os-release parsing was never occurring. This moves all logic to the first check and then attempts to parse the data from /etc/os-release if the file exists (2015+). Slightly harder to grok due to the funky sh string check we have no, but it should be functional on all systems w/o risking impact to other RHEL systems. Signed-off-by: Tim Smith <[email protected]>
scotthain
approved these changes
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The elif that looks for /etc/system-release was firing for Amazon 2 and the /etc/os-release parsing was never occurring. This moves all logic to the first check and then attempts to parse the data from /etc/os-release if the file exists (2015+). Slightly harder to grok due to the funky sh string check we have no, but it should be functional on all systems w/o risking impact to other RHEL systems.
Signed-off-by: Tim Smith [email protected]