Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

download url override and checksum updates #237

Merged
merged 6 commits into from
Aug 31, 2017
Merged

download url override and checksum updates #237

merged 6 commits into from
Aug 31, 2017

Conversation

wrightp
Copy link

@wrightp wrightp commented Aug 31, 2017 •
edited
Loading

This change is part of RFC-091. Kitchen supports URL overrides for MSIs without a checksum value. This change allows download URL overrides to be set for bourne and powershell environments with or without a checksum.

See commits for better separation of the changes.

Use cases supported for powershell and bourne:

  • Incorporate checksum when set with download_url_override
  • Validate local cached files and handle appropriately
    • Checksum mismatch results in downloading new file and re-verifying checksum
    • Checksum match results in directly installing the cached file
    • Checksum not specified results in downloading new file and skipping checksum verification

Known issue (non-regression): checksum verification is broken in Ubuntu 14.04

@wrightp wrightp requested a review from a team August 31, 2017 15:50
@wrightp wrightp force-pushed the wrightp/rfc091-download-url-override-checksum branch 4 times, most recently from 25597e1 to 63b29f6 Compare August 31, 2017 16:12
@wrightp wrightp force-pushed the wrightp/rfc091-download-url-override-checksum branch from 63b29f6 to b53536a Compare August 31, 2017 16:15
@wrightp wrightp merged commit 4d66f59 into master Aug 31, 2017
chef-ci pushed a commit that referenced this pull request Aug 31, 2017
Update CHANGELOG.md with details from pull request #237
4bb7775
@wrightp wrightp mentioned this pull request Aug 31, 2017
Merged
@tas50 tas50 added Expeditor: Skip Version Bump Used to skip built_in:bump_version and removed Version: Skip Bump labels Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schisamo schisamo schisamo approved these changes

Assignees
No one assigned
Labels
Expeditor: Skip Version Bump Used to skip built_in:bump_version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wrightp @schisamo @tas50