Add install_strategy option to bootstrap install scripts #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Wright <[email protected]>
Signed-off-by: Patrick Wright <[email protected]>
wrightp
force-pushed
the
wrightp/install-strategy
branch
from
08c36dd to
d3048e7
Compare
wrightp
changed the title
scotthain
suggested changes
Aug 16, 2017
| @@ -0,0 +1,11 @@ | |||
| execute "bundle exec ruby -e \"require 'mixlib/install'; puts Mixlib::Install.new(product_name: 'chef', product_version: :latest, channel: :stable, install_command_options: {install_strategy: 'once'}).install_command\" > ../.acceptance_data/ubuntu_install_command_once.sh" do | |||
There was a problem hiding this comment.
Can we maybe do a heredoc or something just to make this easier to read?
There was a problem hiding this comment.
You're not supposed to look at that @scotthain❗️
There was a problem hiding this comment.
I added a generic comment to all provision recipes
| @@ -0,0 +1,12 @@ | |||
| execute "bundle exec ruby -e \"require 'mixlib/install'; puts Mixlib::Install.install_ps1, 'install -install_strategy once'\" > ../.acceptance_data/powershell_install_once.ps1" do | |||
Signed-off-by: Patrick Wright <[email protected]>
coderanger
reviewed
Aug 16, 2017
| ) | ||
|
|
||
| if ((Test-Path "$env:systemdrive\opscode\$project\embedded") -and ($install_strategy -eq 'once')) { |
There was a problem hiding this comment.
Is there a reason for the mismatch on which path is checked on bash vs. powershell (root vs root/embedded)?
scotthain
approved these changes
Aug 16, 2017
schisamo
approved these changes
Aug 16, 2017
chef-ci
pushed a commit
that referenced
this pull request
Aug 17, 2017
tas50
added
Expeditor: Skip Version Bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of JEX-643.
When
install_strategyis set tooncethe install scripts will not install packages when the product is already installed (validated by root paths). All other conditions behave in the current manner which is to always install.