Add node_count to stale node json output. #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To help make decisions when processing stale nodes having the total number of nodes available is very helpful.
jeremymv2
suggested changes
Oct 19, 2017
lib/chef/knife/tidy_server_report.rb
Outdated
| @@ -62,7 +62,7 @@ def run | |||
| end | |||
| end | |||
|
|
|||
| stale_nodes_hash = {'threshold_days': node_threshold, 'count': stale_nodes.count, 'list': stale_nodes} | |||
| stale_nodes_hash = {'threshold_days': node_threshold, 'node_count': node.count, 'count': stale_nodes.count, 'list': stale_nodes} | |||
There was a problem hiding this comment.
@MarkGibbons this should be nodes.count, not node.count, right?
Just a small nit-pick, can we change the 'node_count' key to org_total_node_count to make it clearer what the number is?
If you can get those two adjustments made, I'll merge this in!
Thank you!!
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help make decisions when processing stale nodes having the total number of nodes available
is very helpful.