Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chef 15: Fix ssh user set from cli #8558

Merged
merged 1 commit into from
May 28, 2019
Merged

Chef 15: Fix ssh user set from cli #8558

merged 1 commit into from
May 28, 2019

Conversation

dheerajd-msys
Copy link
Contributor

@dheerajd-msys dheerajd-msys commented May 16, 2019 •
edited
Loading

Signed-off-by: dheerajd-msys [email protected]

This fixes the ssh_user setting if we provide from CLI rather than on knife.rb

Description

-- config_value now returns the ssh_user value too if set in CLI.

Related Issue

Fixes chef/knife-ec2#574

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@dheerajd-msys
Fix ssh user set from cli
3818342 
Signed-off-by: dheerajd-msys <[email protected]>
@dheerajd-msys dheerajd-msys changed the title Fix ssh user set from cli [CHEF-15]Fix ssh user set from cli May 17, 2019
@btm btm requested a review from marcparadise May 17, 2019 19:44
@btm btm changed the title [CHEF-15]Fix ssh user set from cli Chef 15: Fix ssh user set from cli May 25, 2019
@btm btm merged commit 8ce98d2 into chef:master May 28, 2019
@lock
Copy link

lock bot commented Jun 12, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcparadise marcparadise marcparadise approved these changes

@btm btm btm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chef 15: knife ec2 server create fails if we don't set ssh_user in knife.rb and paas in CLI as --ssh-user`
3 participants
@dheerajd-msys @btm @marcparadise