Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting mode for openssl_dhparam after creation #8245

Merged
merged 5 commits into from
Feb 22, 2019

Conversation

btm
Copy link
Contributor

@btm btm commented Feb 21, 2019

Replaces #8108
Fixes #8099

Signed-off-by: dheerajd-msys <[email protected]>
Signed-off-by: dheerajd-msys <[email protected]>
@btm btm requested a review from a team February 21, 2019 20:48
Reduce this down to a single file resource

Signed-off-by: Bryan McLellan <[email protected]>
@btm btm force-pushed the btm/MSYS-955_openssl_dhparam_mode_fix branch from 0960614 to 5b22f65 Compare February 21, 2019 23:15
@dheerajd-msys
Copy link
Contributor

Tested this PR and it is working as expected

root@dh-openssl-param:~/chef# bundle exec chef-apply ../openssl_dhparam.rb
Recipe: (chef-apply cookbook)::(chef-apply recipe)
  * openssl_dhparam[/etc/ssl/certs/dhparam.pem] action create
    * file[/etc/ssl/certs/dhparam.pem] action create
      - change mode from '0640' to '0600'

root@dh-openssl-param:~/chef# bundle exec chef-apply ../openssl_dhparam.rb
Recipe: (chef-apply cookbook)::(chef-apply recipe)
  * openssl_dhparam[/etc/ssl/certs/dhparam.pem] action create
    * file[/etc/ssl/certs/dhparam.pem] action create (up to date)
     (up to date)

root@dh-openssl-param:~/chef# bundle exec chef-apply ../openssl_dhparam.rb
Recipe: (chef-apply cookbook)::(chef-apply recipe)
  * openssl_dhparam[/etc/ssl/certs/dhparam.pem] action create
    * file[/etc/ssl/certs/dhparam.pem] action create
      - change owner from 'root' to 'azure'
      - change group from 'root' to 'azure'

@btm
Copy link
Contributor Author

btm commented Feb 22, 2019

Thanks @dheerajd-msys !

@btm btm merged commit cfb841d into master Feb 22, 2019
@chef-ci chef-ci deleted the btm/MSYS-955_openssl_dhparam_mode_fix branch February 22, 2019 12:30
@lock
Copy link

lock bot commented Mar 19, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants