Knife Bootstrap: Passing config_log_level and config_log_location from config.rb #5502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamont-granquist
changed the title
dheerajd-msys
force-pushed
the
dheeraj/configurable_log_details
branch
from
83a5661 to
31a168f
Compare
|
@dheerajd-msys you'll need to update the specs that have blown up travis, but otherwise this is good, thank you! |
…ed specs failure Signed-off-by: dheerajd-msys <[email protected]>
dheerajd-msys
force-pushed
the
dheeraj/configurable_log_details
branch
from
31a168f to
6949868
Compare
NimishaS
suggested changes
Nov 15, 2016
| @@ -69,7 +69,8 @@ def trusted_certs | |||
|
|
|||
| def config_content | |||
| client_rb = <<-CONFIG | |||
| log_location STDOUT | |||
| log_level :#{@chef_config[:config_log_level]} | |||
| log_location "#{@chef_config[:config_log_location]}" | |||
There was a problem hiding this comment.
There are two possible issues that may require fix:
- What happens if
config_log_levelandconfig_log_locationare not passed? Are the values oflog_levelandlog_locationgetting passed in that case? - Is
config_log_location STDOUTgetting passed successfully?
There was a problem hiding this comment.
We should make sure we keep the default log location of STDOUT.
Signed-off-by: dheerajd-msys <[email protected]>
dheerajd-msys
force-pushed
the
dheeraj/configurable_log_details
branch
2 times, most recently
from
1b04c52 to
c961abe
Compare
Signed-off-by: dheerajd-msys <[email protected]>
dheerajd-msys
force-pushed
the
dheeraj/configurable_log_details
branch
from
c961abe to
63a6d5e
Compare
thommay
approved these changes
Nov 23, 2016
btm
approved these changes
Nov 23, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Passing config_log_level and config_log_location from config.rb
Issues Resolved
#1452
Check List