Support ssl (--[no-]ssl option)

[sawanoboly]

update for us and #86 .

[jaymzh]

Well, that was easier than I thought it'd be. Nice!!! :)

@odcinek check this awesomeness out. :)

👍

I technically have merge capability here but lets see the tests pass as well as make sure no one at ChefInc has any objections.

[odcinek]

woot 👍

[sawanoboly]

@jaymzh @odcinek
Thanks for review 😄

Regards,

[jkeiser]

That is pretty easy! Nice!

[jkeiser]

I'll drop this in the 3.0 release (coming soon now that enterprise support is pedant clean).

[sawanoboly]

@jkeiser
Thanks 😃

A supplementary explanation, I have merged and tested this function in oc-chef-pedant branch(become 3.0?) locally. It works.

[jaymzh]

This doesn't seem to work ... at least not with the omnibus build... knife (10, 11, and 12) get a connection refused on a knife cookbook upload -a after the first several requests:

...
DEBUG: Initiating PUT to http://HOSTNAME_HERE:5460/file_store/checksums/f626ed24a129a4f89103b0b2f43f5542
DEBUG: ---- HTTP Request Header Data: ----
DEBUG: Chef::HTTP calling Chef::HTTP::ValidateContentLength#handle_request
...
DEBUG: Content-Length: 666
DEBUG: Content-Length: 666
/opt/chef/embedded/lib/ruby/2.1.0/net/protocol.rb:211:in `write': Connection reset by peer (Errno::ECONNRESET)

This is with chef-12 rc1, but we get the same problem with chef-10 and chef-11.

chef-zero doesn't seem to notice or care... from that side, with debug on, I see:

--- RESPONSE (201) ---
{
  "uri": "http://HOSTNAME_HERE:5460/sandboxes/1",
  "checksums": {
     ...
  },
  "sandbox_id": "1"
}
--- END RESPONSE ---

and nothing else. CHef zero is still happy and will still accept new connections, but knife will continue to fail after the initial sandbox report.

[jaymzh]

oh, and:

$ /opt/chef/embedded/bin/chef-zero --version
3.2

again, from chef 12 rc1

[sawanoboly]

@jaymzh
hmm .. I seem that chef-zero(3.2) has bug on filesystem backend. I think it has caused some problems.

[jaymzh]

You talking about #99? The symptom is pretty different, we get no has_key? errors. We had similar problems with chef-zero 2x... but I'll investigate more.

[sawanoboly]

@jaymzh
I understand. I have reproduced this error.

 % knife cookbook upload --all 
ffi-yajl/json_gem is deprecated, these monkeypatches will be dropped shortly
Uploading apache2      [1.0.0]
Uploading php          [1.0.0]
ERROR: Errno::EPIPE: Broken pipe

Maybe, the URI scheme of response must be https when using ssl.
I'll try to fix it.

[sawanoboly]

@jaymzh

I have fixed it 😃 Please try #104.

[jaymzh]

You da man, thanks!