Fix IPV6 support #50
Merged
Fix IPV6 support #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In c3373e4, @danielsdeleo added support for IPV6, but I didn't understand the purpose of the bracket notation. I thought they were part of the `host`, but they are actually part of the URL. We _need_ the brackets in the URL, but we _cannot_ have the brackets in the host.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In c3373e4, @danielsdeleo added support for IPV6, but I didn't understand the purpose of the bracket notation. I thought they were part of the
host, but they are actually part of the URL. We need the brackets in the URL, but we cannot have the brackets in the host.